[PATCH] D18262: [clang-tidy] Skip reporting of not applicable fixes.

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 18 06:07:02 PDT 2016


aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added a comment.

Thank you for working on this! A question below, but also, the patch is missing test cases for the change.


================
Comment at: ClangTidy.cpp:144
@@ -138,1 +143,3 @@
+       
+        Diag << FixItHint::CreateReplacement(Range, Fix.getReplacementText());
         ++TotalFixes;
----------------
Is there a purpose to emitting the CreateReplacement if the fix isn't applicable?


http://reviews.llvm.org/D18262





More information about the cfe-commits mailing list