[PATCH] D17877: [OpenMP] Base support for target directive codegen on NVPTX device.

[Alexey Bataev via cfe-commits]

ABataev added inline comments.

================
Comment at: lib/CodeGen/CGOpenMPRuntime.h:69
@@ +68,3 @@
+  /// evaluates to false.
+  virtual void emitTargetOutlinedFunctionHelper(const OMPExecutableDirective &D,
+                                                StringRef ParentName,
----------------
arpith-jacob wrote:
> Do we need 'virtual'?  This function needs to be called by the NVPTX implementation (in emitTargetOutlinedFunction) but doesn't need to be overridden.
I we don't need it in 'CGOpenMPRuntime', then why it is here?


http://reviews.llvm.org/D17877