[PATCH] D17877: [OpenMP] Base support for target directive codegen on NVPTX device.

Arpith Jacob via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 9 07:59:16 PST 2016


arpith-jacob marked 9 inline comments as done.

================
Comment at: lib/CodeGen/CGOpenMPRuntime.h:69
@@ +68,3 @@
+  /// evaluates to false.
+  virtual void emitTargetOutlinedFunctionHelper(const OMPExecutableDirective &D,
+                                                StringRef ParentName,
----------------
Do we need 'virtual'?  This function needs to be called by the NVPTX implementation (in emitTargetOutlinedFunction) but doesn't need to be overridden.


http://reviews.llvm.org/D17877





More information about the cfe-commits mailing list