[PATCH] D17434: [Clang-tidy] Make readability-container-size-empty working with STL string

[David Blaikie via cfe-commits]

On Fri, Feb 19, 2016 at 10:25 AM, Eugene Zelenko via cfe-commits <
cfe-commits at lists.llvm.org> wrote:

> Eugene.Zelenko added a comment.
>
> Also I agree that testing is good idea, it doesn't make sense in current
> incarnation which test only vector and set and only with containers' code
> snippets instead of real implementations. I wrote about last issue in
> cfe-dev, but idea was rejected.
>

Not sure I quite follow why stub implementations wouldn't be a valid test
strategy here?


> Other issue is how to avoid code duplication for test conditions. Probably
> tests should be generated from templates for each container or should
> contain container definition and include shared test body.
>

Are the tests really long enough to have a lot of duplication worth
reducing/removing? Seems like the code should be pretty short...
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160219/44300a61/attachment.html>