[PATCH] D17434: [Clang-tidy] Make readability-container-size-empty working with STL string

Eugene Zelenko via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 19 10:25:16 PST 2016


Eugene.Zelenko added a comment.

Also I agree that testing is good idea, it doesn't make sense in current incarnation which test only vector and set and only with containers' code snippets instead of real implementations. I wrote about last issue in cfe-dev, but idea was rejected.

Other issue is how to avoid code duplication for test conditions. Probably tests should be generated from templates for each container or should contain container definition and include shared test body.


Repository:
  rL LLVM

http://reviews.llvm.org/D17434





More information about the cfe-commits mailing list