[PATCH] D17253: Cleanup of analyzer scripts as suggested by pychecker and pep8
Alexander Riccio via cfe-commits
cfe-commits at lists.llvm.org
Mon Feb 15 14:03:01 PST 2016
ariccio added a comment.
Whoops, forgot to submit my earlier comments. Responding to comments right now...
================
Comment at: C:/LLVM/llvm/tools/clang/utils/analyzer/CmpRuns.py:31
@@ -30,3 +30,3 @@
import plistlib
-import CmpRuns
+import CmpRuns # ?
----------------
This file imports itself?
I wasn't sure if I could eliminate this.
================
Comment at: C:/LLVM/llvm/tools/clang/utils/analyzer/SATestBuild.py:62
@@ -60,3 +61,3 @@
def detectCPUs():
"""
----------------
Should this be replaced with `multiprocessing.cpu_count`?
http://reviews.llvm.org/D17253
More information about the cfe-commits
mailing list