[PATCH] D17253: Cleanup of analyzer scripts as suggested by pychecker and pep8

Anna Zaks via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 15 12:42:35 PST 2016


zaks.anna requested changes to this revision.
zaks.anna added a comment.
This revision now requires changes to proceed.

Not sure how you got these changes, but some of them seem wrong and some seem inconsistently applied.

Has this been tested?


================
Comment at: C:/LLVM/llvm/tools/clang/utils/analyzer/CmpRuns.py:194
@@ -182,3 +193,3 @@
 # Backward compatibility API.
-def loadResults(path, opts, root = "", deleteEmpty=True):
+def loadResults(path, opts, root="", deleteEmpty=True):
     return loadResultsFromSingleRun(SingleRunInfo(path, root, opts.verboseLog),
----------------
PEP 0008: Don't use spaces around the = sign when used to indicate a keyword argument or a default parameter value.




http://reviews.llvm.org/D17253





More information about the cfe-commits mailing list