[libcxx] r260012 - Cleanup node-type handling in the unordered containers

[Eric Fiselier via cfe-commits]

(Re-adding the list)

Re-committed as r260431. Let me know if there is any more breakage.

@Tim Are these tests in the clang test suite? Marshall and I were just
talking about removing <ext/hash_map> all together.
Could you explain who still uses it?


On Mon, Feb 8, 2016 at 4:52 PM, Eric Fiselier <eric at efcs.ca> wrote:

> Hey Tim,
>
> Sorry about the breakage. I've reverted the commit in r260172. I'll make
> sure that gnu_cxx::hash_map continues to work before recommitting.
>
> /Eric
>
>
> On Mon, Feb 8, 2016 at 2:23 PM, Tim Northover <t.p.northover at gmail.com>
> wrote:
>
>> Hi Eric,
>>
>> On 6 February 2016 at 16:36, Eric Fiselier via cfe-commits
>> <cfe-commits at lists.llvm.org> wrote:
>> > Cleanup node-type handling in the unordered containers
>>
>> This seems to have broken __gnu_cxx::hash_map (used by hash.cpp and
>> hash2.cpp in the test-suite). A smaller reproducer is:
>>
>> #include <ext/hash_map>
>> typedef __gnu_cxx::hash_map<const char*, int, __gnu_cxx::hash<const
>> char*> > HM;
>> int foo(HM &h) {
>>   return h["wibble"];
>> }
>>
>> I don't suppose you could take a look? Or is that already planned and
>> what you're talking about with:
>>
>> > This patch will be followed up shortly with fixes for various
>> unordered_map
>> > fixes.
>>
>> Cheers.
>>
>> Tim.
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160210/dc0567c3/attachment.html>