[libcxx] r260012 - Cleanup node-type handling in the unordered containers

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 8 15:52:27 PST 2016


Hey Tim,

Sorry about the breakage. I've reverted the commit in r260172. I'll make
sure that gnu_cxx::hash_map continues to work before recommitting.

/Eric


On Mon, Feb 8, 2016 at 2:23 PM, Tim Northover <t.p.northover at gmail.com>
wrote:

> Hi Eric,
>
> On 6 February 2016 at 16:36, Eric Fiselier via cfe-commits
> <cfe-commits at lists.llvm.org> wrote:
> > Cleanup node-type handling in the unordered containers
>
> This seems to have broken __gnu_cxx::hash_map (used by hash.cpp and
> hash2.cpp in the test-suite). A smaller reproducer is:
>
> #include <ext/hash_map>
> typedef __gnu_cxx::hash_map<const char*, int, __gnu_cxx::hash<const char*>
> > HM;
> int foo(HM &h) {
>   return h["wibble"];
> }
>
> I don't suppose you could take a look? Or is that already planned and
> what you're talking about with:
>
> > This patch will be followed up shortly with fixes for various
> unordered_map
> > fixes.
>
> Cheers.
>
> Tim.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160208/e18425d5/attachment.html>


More information about the cfe-commits mailing list