r256468 - On {mips, mipsel, mips64, mips64el}-freebsd, we need to pass any -G option to the assembler.

[Dimitry Andric via cfe-commits]

Sorry, but I fail to see where in AddMIPSTargetArgs the -G options are handled?  What is the general idea about the "new style" cleanup?

-Dimitry

> On 14 Jan 2016, at 18:13, Daniel Sanders <Daniel.Sanders at imgtec.com> wrote:
> 
> Did you get an answer to this question? I think it's just that the FreeBSD class hasn't refactored to that style yet.
> That switch statement is getting quite large so it would be a nice cleanup to switch to that style.
> 
>> -----Original Message-----
>> From: cfe-commits [mailto:cfe-commits-bounces at lists.llvm.org] On Behalf
>> Of Joerg Sonnenberger via cfe-commits
>> Sent: 27 December 2015 11:59
>> To: cfe-commits at lists.llvm.org
>> Subject: Re: r256468 - On {mips, mipsel, mips64, mips64el}-freebsd, we need
>> to pass any -G option to the assembler.
>> 
>> On Sun, Dec 27, 2015 at 10:36:44AM -0000, Dimitry Andric via cfe-commits
>> wrote:
>>> Author: dim
>>> Date: Sun Dec 27 04:36:44 2015
>>> New Revision: 256468
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=256468&view=rev
>>> Log:
>>> On {mips,mipsel,mips64,mips64el}-freebsd, we need to pass any -G option
>> to the assembler.
>> 
>> Why is this reinventing the wheel and not using AddMIPSTargetArgs?
>> 
>> Joerg
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160114/74b40de7/attachment.sig>