[PATCH] D13453: Always generate cmake config files

[Chris Bieneman via cfe-commits]

Apologies for reviving a long dead thread, but I think we need to re-evalute this change.

With CMake 3.4 I’m seeing some nasty error spew on our internal builds. The spew can be reproduced with the following CMake invocation:

> cmake -G Ninja -DLLVM_ENABLE_PIC=Off -DLLVM_INSTALL_TOOLCHAIN_ONLY=On ../llvm

It seems to me that problem is that libclang’s static version depends on LLVM libraries which are not included in the ClangTargets export group. This wasn’t an issue before this change because the LLVM targets were external to CMake so it didn’t expect them to be in the export.

I think the right solution here is actually to make the clang targets export as part of the LLVMExports group when Clang is built with LLVM.

I’m about to send a patch out for review which addresses this, please provide feedback.

Thanks,
-Chris

> On Oct 9, 2015, at 7:43 PM, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
> 
> chapuni closed this revision.
> chapuni added a comment.
> 
> Applied in r249935, thanks!
> 
> 
> http://reviews.llvm.org/D13453
> 
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160113/4d75fd9f/attachment.html>