<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Apologies for reviving a long dead thread, but I think we need to re-evalute this change.<div class=""><br class=""></div><div class="">With CMake 3.4 I’m seeing some nasty error spew on our internal builds. The spew can be reproduced with the following CMake invocation:</div><div class=""><br class=""></div><div class=""><div style="margin: 0px; line-height: normal; font-family: 'Andale Mono'; color: rgb(56, 193, 255); background-color: rgb(0, 0, 0);" class=""><div style="margin: 0px; line-height: normal;" class=""><span style="font-variant-ligatures: no-common-ligatures; color: #29f914" class="">> </span><span style="font-variant-ligatures: no-common-ligatures; color: #457bf9" class="">cmake</span><span style="font-variant-ligatures: no-common-ligatures; color: #29f914" class=""> </span>-G<span style="font-variant-ligatures: no-common-ligatures; color: #29f914" class=""> </span>Ninja<span style="font-variant-ligatures: no-common-ligatures; color: #29f914" class=""> </span>-DLLVM_ENABLE_PIC=Off<span style="font-variant-ligatures: no-common-ligatures; color: #29f914" class=""> </span>-DLLVM_INSTALL_TOOLCHAIN_ONLY=On<span style="font-variant-ligatures: no-common-ligatures; color: #29f914" class=""> </span>../llvm</div></div></div><div class=""><br class=""></div><div class="">It seems to me that problem is that libclang’s static version depends on LLVM libraries which are not included in the ClangTargets export group. This wasn’t an issue before this change because the LLVM targets were external to CMake so it didn’t expect them to be in the export.</div><div class=""><br class=""></div><div class="">I think the right solution here is actually to make the clang targets export as part of the LLVMExports group when Clang is built with LLVM.</div><div class=""><br class=""></div><div class="">I’m about to send a patch out for review which addresses this, please provide feedback.</div><div class=""><br class=""></div><div class="">Thanks,</div><div class="">-Chris</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Oct 9, 2015, at 7:43 PM, NAKAMURA Takumi <<a href="mailto:geek4civic@gmail.com" class="">geek4civic@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">chapuni closed this revision.<br class="">chapuni added a comment.<br class=""><br class="">Applied in r249935, thanks!<br class=""><br class=""><br class=""><a href="http://reviews.llvm.org/D13453" class="">http://reviews.llvm.org/D13453</a><br class=""><br class=""><br class=""><br class=""></div></div></blockquote></div><br class=""></div></body></html>