Proposing a fix for revision 256933

[Samuel F Antao via cfe-commits]

Hi Amjad,

Thanks for detecting the issue. Your fix was committed in r257065.

Thanks again,
Samuel



From:	"Aboud, Amjad" <amjad.aboud at intel.com>
To:	Samuel F Antao/Watson/IBM at IBMUS
Cc:	"cfe-commits at lists.llvm.org" <cfe-commits at lists.llvm.org>
Date:	01/07/2016 08:40 AM
Subject:	Proposing a fix for revision 256933



Hi Samuel,
I noticed that the two tests you added in the below commit have a minor
issue.
“target_codegen_registration_naming.cpp” is failing on my local machine
(Win32).
“target_codegen_registration.cpp” is not failing, but it contain “CHECK…”
lines with wrong syntax that make FileCheck ignore them.

Please, see the attach patch I suggest for fixing these test.

Thanks,
Amjad

Author: sfantao
Date: Wed Jan  6 07:42:12 2016
New Revision: 256933

URL: http://llvm.org/viewvc/llvm-project?rev=256933&view=rev
Log:
[OpenMP] Reapply rL256842: [OpenMP] Offloading descriptor registration and
device codegen.

This patch attempts to fix the regressions identified when the patch was
committed initially.

Thanks to Michael Liao for identifying the fix in the offloading metadata
generation
related with side effects in evaluation of function arguments.


Added:
    cfe/trunk/test/OpenMP/target_codegen_registration.cpp
    cfe/trunk/test/OpenMP/target_codegen_registration_naming.cpp
Modified:
    cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td
    cfe/trunk/include/clang/Basic/LangOptions.def
    cfe/trunk/include/clang/Basic/LangOptions.h
    cfe/trunk/include/clang/Driver/CC1Options.td
    cfe/trunk/include/clang/Driver/Options.td
    cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
    cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h
    cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp
    cfe/trunk/lib/CodeGen/CodeGenModule.cpp
    cfe/trunk/lib/Frontend/CompilerInvocation.cpp
    cfe/trunk/lib/Serialization/ASTReader.cpp
    cfe/trunk/lib/Serialization/ASTWriter.cpp
    cfe/trunk/test/OpenMP/target_codegen.cpp
    cfe/trunk/test/OpenMP/target_codegen_global_capture.cpp
    cfe/trunk/test/OpenMP/target_map_codegen.cpp
    cfe/trunk/test/OpenMP/target_messages.cpp



---------------------------------------------------------------------
Intel Israel (74) Limited


This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.[attachment
"r256933-Fix.patch" deleted by Samuel F Antao/Watson/IBM]


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160107/379ddb19/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: graycol.gif
Type: image/gif
Size: 105 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160107/379ddb19/attachment-0001.gif>