<html><body><p>Hi Amjad,<br><br>Thanks for detecting the issue. Your fix was committed in r257065.<br><br>Thanks again,<br>Samuel<br><br><img width="16" height="16" src="cid:1__=8FBBF5A0DFC123FC8f9e8a93df938690918c8FB@" border="0" alt="Inactive hide details for "Aboud, Amjad" ---01/07/2016 08:40:08 AM---Hi Samuel, I noticed that the two tests you added in the b"><font color="#424282">"Aboud, Amjad" ---01/07/2016 08:40:08 AM---Hi Samuel, I noticed that the two tests you added in the below commit have a minor issue.</font><br><br><font size="2" color="#5F5F5F">From: </font><font size="2">"Aboud, Amjad" <amjad.aboud@intel.com></font><br><font size="2" color="#5F5F5F">To: </font><font size="2">Samuel F Antao/Watson/IBM@IBMUS</font><br><font size="2" color="#5F5F5F">Cc: </font><font size="2">"cfe-commits@lists.llvm.org" <cfe-commits@lists.llvm.org></font><br><font size="2" color="#5F5F5F">Date: </font><font size="2">01/07/2016 08:40 AM</font><br><font size="2" color="#5F5F5F">Subject: </font><font size="2">Proposing a fix for revision 256933</font><br><hr width="100%" size="2" align="left" noshade style="color:#8091A5; "><br><br><br><font face="Calibri">Hi Samuel,</font><br><font face="Calibri">I noticed that the two tests you added in the below commit have a minor issue.</font><br><font face="Calibri">“target_codegen_registration_naming.cpp” is failing on my local machine (Win32).</font><br><font face="Calibri">“target_codegen_registration.cpp” is not failing, but it contain “CHECK…” lines with wrong syntax that make FileCheck ignore them.</font><br><font face="Calibri"> </font><br><font face="Calibri">Please, see the attach patch I suggest for fixing these test.</font><br><font face="Calibri"> </font><br><font face="Calibri">Thanks,</font><br><font face="Calibri">Amjad</font><br><font face="Calibri"> </font><br><font face="Courier New">Author: sfantao</font><br><font face="Courier New">Date: Wed Jan 6 07:42:12 2016</font><br><font face="Courier New">New Revision: 256933</font><br><font face="Courier New"> </font><br><font face="Courier New">URL: </font><a href="http://llvm.org/viewvc/llvm-project?rev=256933&view=rev"><u><font color="#0563C1" face="Courier New">http://llvm.org/viewvc/llvm-project?rev=256933&view=rev</font></u></a><br><font face="Courier New">Log:</font><br><font face="Courier New">[OpenMP] Reapply rL256842: [OpenMP] Offloading descriptor registration and device codegen.</font><br><font face="Courier New"> </font><br><font face="Courier New">This patch attempts to fix the regressions identified when the patch was committed initially. </font><br><font face="Courier New"> </font><br><font face="Courier New">Thanks to Michael Liao for identifying the fix in the offloading metadata generation </font><br><font face="Courier New">related with side effects in evaluation of function arguments. </font><br><font face="Courier New"> </font><br><font face="Courier New"> </font><br><font face="Courier New">Added:</font><br><font face="Courier New"> cfe/trunk/test/OpenMP/target_codegen_registration.cpp</font><br><font face="Courier New"> cfe/trunk/test/OpenMP/target_codegen_registration_naming.cpp</font><br><font face="Courier New">Modified:</font><br><font face="Courier New"> cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td</font><br><font face="Courier New"> cfe/trunk/include/clang/Basic/LangOptions.def</font><br><font face="Courier New"> cfe/trunk/include/clang/Basic/LangOptions.h</font><br><font face="Courier New"> cfe/trunk/include/clang/Driver/CC1Options.td</font><br><font face="Courier New"> cfe/trunk/include/clang/Driver/Options.td</font><br><font face="Courier New"> cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp</font><br><font face="Courier New"> cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h</font><br><font face="Courier New"> cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp</font><br><font face="Courier New"> cfe/trunk/lib/CodeGen/CodeGenModule.cpp</font><br><font face="Courier New"> cfe/trunk/lib/Frontend/CompilerInvocation.cpp</font><br><font face="Courier New"> cfe/trunk/lib/Serialization/ASTReader.cpp</font><br><font face="Courier New"> cfe/trunk/lib/Serialization/ASTWriter.cpp</font><br><font face="Courier New"> cfe/trunk/test/OpenMP/target_codegen.cpp</font><br><font face="Courier New"> cfe/trunk/test/OpenMP/target_codegen_global_capture.cpp</font><br><font face="Courier New"> cfe/trunk/test/OpenMP/target_map_codegen.cpp</font><br><font face="Courier New"> cfe/trunk/test/OpenMP/target_messages.cpp</font><br><font face="Calibri"> </font><p><font size="4">---------------------------------------------------------------------<br>Intel Israel (74) Limited</font><p><font size="4">This e-mail and any attachments may contain confidential material for<br>the sole use of the intended recipient(s). Any review or distribution<br>by others is strictly prohibited. If you are not the intended<br>recipient, please contact the sender and delete all copies.[attachment "r256933-Fix.patch" deleted by Samuel F Antao/Watson/IBM] </font><p><BR>
</body></html>