[PATCH] D15223: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics.

[Eric Christopher via cfe-commits]

On Mon, Dec 14, 2015 at 11:05 AM Tim Northover <t.p.northover at gmail.com>
wrote:

> > I don't think it's going to be even vaguely that bad here and that you're
> > blowing it a bit out of proportion. [...] It does make the tests a
> little harder
> > to write, but having done a bunch of them it's not that bad.
>
> I've also tried to write such tests in the past, and I did find it that
> bad.
>
> > Also you're relying on the behavior of
> > backend optimizations to figure out what's going on with your clang IR
> > generation which also seems less than optimal.
>
> I think it's fine if it leads to simpler tests that are easier to
> maintain. It's not completely isolated, but none of the testing we do
> really is.
>
>
There really is a pretty good separation of concerns and for a lot if not
most of the tests here all the difference is checking is the arguments,
keeping track of an alloca and making sure that goes is pretty simple and
not really hard for a test.

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20151214/2835922d/attachment.html>