[PATCH] D15223: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics.

Tim Northover via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 14 11:05:30 PST 2015


> I don't think it's going to be even vaguely that bad here and that you're
> blowing it a bit out of proportion. [...] It does make the tests a little harder
> to write, but having done a bunch of them it's not that bad.

I've also tried to write such tests in the past, and I did find it that bad.

> Also you're relying on the behavior of
> backend optimizations to figure out what's going on with your clang IR
> generation which also seems less than optimal.

I think it's fine if it leads to simpler tests that are easier to
maintain. It's not completely isolated, but none of the testing we do
really is.

Tim.


More information about the cfe-commits mailing list