[PATCH] D14653: [libcxx] Introduce the mechanism for fixing -fno-exceptions test failures.

Asiri Rathnayake via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 10 10:04:28 PST 2015


rmaprath updated this revision to Diff 42440.
rmaprath added a comment.

Addressing review comments by @EricWF:

- Introduced `_LIBCPP_THROW` macro to appropriately throw or call the no-exceptions report routine to handle the exceptional situation (avoid the overhead of a function call in the default library). The compiler may be able to inline the call to `__throw_helper` to achieve the same effect, but wouldn't hurt to make it explicit.

- Renamed `__throw_helper` to `__libcxx_noexceptions_report` as appropriate.

- Added `_LIBCPP_NORETURN` qualifiers to both `__libcxx_noexceptions_report` and `__libcxx_noexceptions_abort`.


http://reviews.llvm.org/D14653

Files:
  include/__config
  include/array
  test/std/containers/sequences/array/at.pass.cpp
  test/support/noexcept.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D14653.42440.patch
Type: text/x-patch
Size: 4609 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20151210/d372e1f5/attachment.bin>


More information about the cfe-commits mailing list