[PATCH] D14653: [libcxx] Introduce the mechanism for fixing -fno-exceptions test failures.

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 10 05:08:38 PST 2015


EricWF added a comment.

Before you spend time changing the tests to use `TEST_TRY`/`TEST_CATCH` I would like somebody else to weigh in. I don't really think my solution is that great either.  @jroelofs, @mclow any thoughts?

A couple of more thoughts:

- Forget what I said about putting it in <type_traits>. I think it's fine in __config

- Because `throw_helper` no longer throws it should probably be renamed to something more appropriate.
- `__throw_helper` and `__libcpp_noexceptions_abort` should probably be marked `_LIBCPP_NORETURN`. I can't think of a sane case where you would want to return.


http://reviews.llvm.org/D14653





More information about the cfe-commits mailing list