[PATCH] D15195: PR4941: Add support for -fno-builtin-foo options.

[hfinkel@anl.gov via cfe-commits]

hfinkel added a subscriber: hfinkel.
hfinkel added a comment.

Can you use a StringSet instead of a vector and avoid all (most) of the code iterating over the vector of builtins being disabled?


================
Comment at: lib/Frontend/CompilerInvocation.cpp:147
@@ +146,3 @@
+        Values.push_back(FuncName);
+      // FIXME: We could warn about invalid/unsupported -fno-builtin-*.
+    }
----------------
I'd remove this; there's no need for Clang to know about all functions that the optimizer knows about, and thus for which adding the nobuiltin attribute might be useful.


http://reviews.llvm.org/D15195