[PATCH] D14653: [libcxx] Introduce the mechanism for fixing -fno-exceptions test failures.

Asiri Rathnayake via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 8 07:06:29 PST 2015


rmaprath updated this revision to Diff 42175.
rmaprath added a comment.

Addressing review comments by @mclow.lists:

Got rid of the `__noexcept` header by moving the `__throw_helper` function into the `__config` header. The `__libcxx_noexceptions_abort` function now takes in an extra parameter containing the error message.

I removed the default call to `abort()` as it would be unwise (and impossible?) to call it from `__config` given its use across many headers. The current expectation is that the users of the no-exceptions library need to provide an implementation of '__libcxx_noexceptions_abort' if they wish to handle exceptional situations occurring within the no-exceptions library, otherwise such states will be simply ignored by the library.


http://reviews.llvm.org/D14653

Files:
  include/__config
  include/array
  test/std/containers/sequences/array/at.pass.cpp
  test/support/noexcept.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D14653.42175.patch
Type: text/x-patch
Size: 4216 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20151208/260dfaac/attachment.bin>


More information about the cfe-commits mailing list