[PATCH] D14502: [PATCH] Do not create a clang-install target for MSVC solutions

[Chris Bieneman via cfe-commits]

> On Nov 9, 2015, at 2:07 PM, Aaron Ballman <aaron.ballman at gmail.com> wrote:
> 
> aaron.ballman added inline comments.
> 
> ================
> Comment at: tools/driver/CMakeLists.txt:58
> @@ -62,1 +57,3 @@
> 
> +if(NOT MSVC)
> +  add_custom_target(install-clang
> ----------------
> beanz wrote:
>> Can you change this to `if(NOT CMAKE_CONFIGURATION_TYPES)`?
>> 
>> With that it won't create the install-clang target for any IDE, which is probably the way I should have done this in the first place.
>> 
>> Other than that LGTM.
>> 
>> Thanks,
>> -Chris
> Thanks, I'll make that modification. Out of curiosity, do you think INSTALL and PACKAGE should be opt-in for MSVC? Not present at all? Always present (as they are currently)?

Not sure I’m really a good person to comment on MSVC as I don’t use it. In general I don’t see harm in it, but this case of having the install-clang target was really just a bug. The purpose of that target is really to provide a convenience mechanism for people using Ninja and Make to only install clang.

Thank you for fixing this,
-Chris

> 
> 
> http://reviews.llvm.org/D14502
> 
> 
>