[PATCH] D14502: [PATCH] Do not create a clang-install target for MSVC solutions

[Aaron Ballman via cfe-commits]

aaron.ballman added inline comments.

================
Comment at: tools/driver/CMakeLists.txt:58
@@ -62,1 +57,3 @@
 
+if(NOT MSVC)
+  add_custom_target(install-clang
----------------
beanz wrote:
> Can you change this to `if(NOT CMAKE_CONFIGURATION_TYPES)`?
> 
> With that it won't create the install-clang target for any IDE, which is probably the way I should have done this in the first place.
> 
> Other than that LGTM.
> 
> Thanks,
> -Chris
Thanks, I'll make that modification. Out of curiosity, do you think INSTALL and PACKAGE should be opt-in for MSVC? Not present at all? Always present (as they are currently)?


http://reviews.llvm.org/D14502