[PATCH] D14502: [PATCH] Do not create a clang-install target for MSVC solutions

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 9 10:28:59 PST 2015


aaron.ballman created this revision.
aaron.ballman added a reviewer: beanz.
aaron.ballman added a subscriber: cfe-commits.

When generating an MSVC solution from CMake, it creates a clang-install project. We do not have any *-install targets as part of MSVC, so this seems out of place (not to mention, a bit strange). This patch disables creation of the clang-install project when making an MSVC solution.

http://reviews.llvm.org/D14502

Files:
  tools/driver/CMakeLists.txt

Index: tools/driver/CMakeLists.txt
===================================================================
--- tools/driver/CMakeLists.txt
+++ tools/driver/CMakeLists.txt
@@ -54,12 +54,15 @@
 install(TARGETS clang
   RUNTIME DESTINATION bin
   COMPONENT clang)
-add_custom_target(install-clang
-  DEPENDS clang
-  COMMAND "${CMAKE_COMMAND}"
-          -DCMAKE_INSTALL_COMPONENT=clang
-          -P "${CMAKE_BINARY_DIR}/cmake_install.cmake")
 
+if(NOT MSVC)
+  add_custom_target(install-clang
+    DEPENDS clang
+    COMMAND "${CMAKE_COMMAND}"
+            -DCMAKE_INSTALL_COMPONENT=clang
+            -P "${CMAKE_BINARY_DIR}/cmake_install.cmake")
+endif()
+
 if(NOT CLANG_LINKS_TO_CREATE)
   set(CLANG_LINKS_TO_CREATE clang++ clang-cl)
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D14502.39716.patch
Type: text/x-patch
Size: 734 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20151109/470dbf71/attachment.bin>


More information about the cfe-commits mailing list