[clang-tools-extra] r252496 - Rewording some of this documentation to describe the check instead of try to rationalize the behavior of the check. The links already provide sufficient rationale.

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 9 10:04:35 PST 2015


Author: aaronballman
Date: Mon Nov  9 12:04:34 2015
New Revision: 252496

URL: http://llvm.org/viewvc/llvm-project?rev=252496&view=rev
Log:
Rewording some of this documentation to describe the check instead of try to rationalize the behavior of the check. The links already provide sufficient rationale.

Modified:
    clang-tools-extra/trunk/docs/clang-tidy/checks/cert-setlongjmp.rst
    clang-tools-extra/trunk/docs/clang-tidy/checks/cert-variadic-function-def.rst

Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/cert-setlongjmp.rst
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/cert-setlongjmp.rst?rev=252496&r1=252495&r2=252496&view=diff
==============================================================================
--- clang-tools-extra/trunk/docs/clang-tidy/checks/cert-setlongjmp.rst (original)
+++ clang-tools-extra/trunk/docs/clang-tidy/checks/cert-setlongjmp.rst Mon Nov  9 12:04:34 2015
@@ -1,10 +1,7 @@
 cert-err52-cpp
 ==============
 
-The C standard library facilities setjmp() and longjmp() can be used to
-simulate throwing and catching exceptions. However, these facilities bypass
-automatic resource management and can result in undefined behavior, commonly
-including resource leaks, and denial-of-service attacks.
+This check flags all call expressions involving setjmp() and longjmp().
 
 This check corresponds to the CERT C++ Coding Standard rule
 `ERR52-CPP. Do not use setjmp() or longjmp()

Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/cert-variadic-function-def.rst
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/cert-variadic-function-def.rst?rev=252496&r1=252495&r2=252496&view=diff
==============================================================================
--- clang-tools-extra/trunk/docs/clang-tidy/checks/cert-variadic-function-def.rst (original)
+++ clang-tools-extra/trunk/docs/clang-tidy/checks/cert-variadic-function-def.rst Mon Nov  9 12:04:34 2015
@@ -1,12 +1,8 @@
 cert-dcl50-cpp
 ========================
 
-A variadic function using an ellipsis has no mechanisms to check the type safety
-of arguments being passed to the function or to check that the number of
-arguments being passed matches the semantics of the function definition.
-Consequently, a runtime call to a C-style variadic function that passes
-inappropriate arguments yields undefined behavior. Such undefined behavior could
-be exploited to run arbitrary code.
+This check flags all function definitions (but not declarations) of C-style
+variadic functions.
 
 This check corresponds to the CERT C++ Coding Standard rule
 `DCL50-CPP. Do not define a C-style variadic function




More information about the cfe-commits mailing list