[PATCH] D13388: Add support for querying the visibility of a cursor

Michael Wu via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 4 20:51:57 PST 2015


michaelwu added inline comments.

================
Comment at: test/Index/symbol-visibility.c:8
@@ +7,3 @@
+// CHECK: FunctionDecl=foo1:3:47visibility=Default
+// CHECK: FunctionDecl=foo2:4:49visibility=Protected
+// CHECK: FunctionDecl=foo3:5:46visibility=Hidden
----------------
skalinichev wrote:
> Are you sure that this is correct?
> Looking at r246931, it seems like the protected visibility is not supported on all platforms.
Not sure about this. For most purposes, default and hidden is all you need so I don't think there's much lost by cutting this part of this test. I was on the fence about whether to test for protected.


http://reviews.llvm.org/D13388





More information about the cfe-commits mailing list