[PATCH] D13388: Add support for querying the visibility of a cursor

Sergey Kalinichev via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 3 23:16:23 PST 2015


skalinichev added a comment.

Well, I think it's ok then. Still there is no test for visibility set from command line case. 
Also adding comment to clang_getCursorVisibility explaining that it also works with visibility set from command line would be very useful.


================
Comment at: test/Index/symbol-visibility.c:8
@@ +7,3 @@
+// CHECK: FunctionDecl=foo1:3:47visibility=Default
+// CHECK: FunctionDecl=foo2:4:49visibility=Protected
+// CHECK: FunctionDecl=foo3:5:46visibility=Hidden
----------------
Are you sure that this is correct?
Looking at r246931, it seems like the protected visibility is not supported on all platforms.


http://reviews.llvm.org/D13388





More information about the cfe-commits mailing list