[PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

Jonathan Roelofs via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 4 08:31:58 PST 2015


jroelofs added a comment.



> Counter proposal, we mark all the currently failing (-fno-exceptions) test cases with:

> 

>   // XFAIL: libcpp-no-exceptions

> 

> 

> This has the following advantages:

> 

> - No need to change buildbots to skip tests

> - The bots will catch any regressions in those tests that are already passing under -fno-exceptions

> - You will be able to monitor my progress with the test fixes using the public (-fno-exceptions) buildbots

> - I don't have to setup local buildbots (this is very difficult for us, infrastructure / legal problems)

> 

>   What do you think?


I think this ^ is a reasonable solution.

Jon

> 

> 

> - Asiri





http://reviews.llvm.org/D14293





More information about the cfe-commits mailing list