[PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

Asiri Rathnayake via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 4 05:02:44 PST 2015


rmaprath added a comment.

In http://reviews.llvm.org/D14293#280982, @rengolin wrote:

> Hi Asiri,
>
> Can I propose a different approach?
>
> We now have a silent buildbot, which will never email people about breakages, but can be publicly monitored by you, me and others. I'm assuming you have access to at least one x86 and one ARM machines, so that you could set up a local buildbot, reporting to the buildmaster, without upsetting anyone else, but where I, Jon, Marshall can also see the progress of all tests being fixed, thus helping approving the patches for future fixes.
>
> You don't need to share any information on the board, just connect to the master and start building...
>
> Once the bot is green, we can add the builds on our own public hardware, avoiding the need for disabling the tests.
>
> cheers,
> --renato


Counter proposal, we mark all the currently failing (-fno-exceptions) test cases with:

  // XFAIL: libcpp-no-exceptions

This has the following advantages:

- No need to change buildbots to skip tests
- The bots will catch any regressions in those tests that are already passing under -fno-exceptions
- You will be able to monitor my progress with the test fixes using the public (-fno-exceptions) buildbots
- I don't have to setup local buildbots (this is very difficult for us, infrastructure / legal problems)

What do you think?

- Asiri


http://reviews.llvm.org/D14293





More information about the cfe-commits mailing list