[PATCH] D12922: Add support for function attribute "notail"

[Akira Hatanaka via cfe-commits]

ping

On Mon, Oct 19, 2015 at 5:59 PM, Akira Hatanaka <ahatanak at gmail.com> wrote:

> ahatanak updated this revision to Diff 37816.
> ahatanak added a comment.
>
> Address review comments:
>
> 1. Renamed the attribute to "not_tail_called".
>
> I chose "not_tail_called" over "notailcall" or "notail" to better
> distinguish it from the attribute that is proposed in
> http://reviews.llvm.org/D12547 (which is tentatively named
> "disable_tail_calls").
>
> 2. Made changes to error-out if a virtual function or an objective-c
> method is marked "not_tail_called".
>
> I made this change because this attribute isn't useful when the compiler
> cannot resolve the function call statically at compile time and it isn't
> important for the use case I have.
>
> 3. Added code examples to AttrDocs.td.
>
>
> http://reviews.llvm.org/D12922
>
> Files:
>   include/clang/Basic/Attr.td
>   include/clang/Basic/AttrDocs.td
>   include/clang/Basic/DiagnosticSemaKinds.td
>   lib/CodeGen/CGCall.cpp
>   lib/Sema/SemaDecl.cpp
>   lib/Sema/SemaDeclAttr.cpp
>   test/CodeGen/attr-no-tail.c
>   test/CodeGenCXX/attr-notail.cpp
>   test/Sema/attr-notail.c
>   test/SemaCXX/attr-notail.cpp
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20151026/dbc3a5f0/attachment.html>