<div dir="ltr">ping<div class="gmail_extra"><br><div class="gmail_quote">On Mon, Oct 19, 2015 at 5:59 PM, Akira Hatanaka <span dir="ltr"><<a href="mailto:ahatanak@gmail.com" target="_blank">ahatanak@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">ahatanak updated this revision to Diff 37816.<br>
ahatanak added a comment.<br>
<br>
Address review comments:<br>
<br>
1. Renamed the attribute to "not_tail_called".<br>
<br>
I chose "not_tail_called" over "notailcall" or "notail" to better distinguish it from the attribute that is proposed in <a href="http://reviews.llvm.org/D12547" rel="noreferrer" target="_blank">http://reviews.llvm.org/D12547</a> (which is tentatively named "disable_tail_calls").<br>
<br>
2. Made changes to error-out if a virtual function or an objective-c method is marked "not_tail_called".<br>
<br>
I made this change because this attribute isn't useful when the compiler cannot resolve the function call statically at compile time and it isn't important for the use case I have.<br>
<br>
3. Added code examples to AttrDocs.td.<br>
<span class=""><br>
<br>
<a href="http://reviews.llvm.org/D12922" rel="noreferrer" target="_blank">http://reviews.llvm.org/D12922</a><br>
<br>
Files:<br>
  include/clang/Basic/Attr.td<br>
  include/clang/Basic/AttrDocs.td<br>
</span>  include/clang/Basic/DiagnosticSemaKinds.td<br>
  lib/CodeGen/CGCall.cpp<br>
  lib/Sema/SemaDecl.cpp<br>
  lib/Sema/SemaDeclAttr.cpp<br>
  test/CodeGen/attr-no-tail.c<br>
  test/CodeGenCXX/attr-notail.cpp<br>
  test/Sema/attr-notail.c<br>
  test/SemaCXX/attr-notail.cpp<br>
<br>
</blockquote></div><br></div></div>