[PATCH] D13549: Added new options to ClangFormat VSIX package.

[Marek Kurdej via cfe-commits]

curdeius added inline comments.

================
Comment at: lib/Driver/Tools.cpp:2356
@@ -2355,3 +2355,3 @@
     CmdArgs.push_back(
-        Args.MakeArgString("-dwarf-version=" + llvm::itostr(DwarfVersion)));
+        Args.MakeArgString("-dwarf-version=" + Twine(DwarfVersion)));
 }
----------------
klimek wrote:
> Seems unrelated?
Oups, I've made a mistake when updating the revision and pulled in the changes from master.
I'll correct this.

================
Comment at: tools/clang-format/ClangFormat.cpp:227
@@ -213,1 +226,3 @@
+      llvm::outs() << """;
+      break;
     default:
----------------
klimek wrote:
> For XML, we should only need "<" and "&". Everything else is just important in a context introduced by "<" or "&".
> The problem with include-sorting is that we'll now need to fully support utf8 input (well, any encoding, to be precise).
> The best way is probably to escape all code points that are outside the ascii range. The problem I see is that we have no idea what encoding the file is in, so I have no clue how we can really resolve this.
> 
Ok. I'll cut it  down to the necessary minimum ('<', '&').
Anyway, I thing it's more urgent to fix the include sorting containing open brackets and later work on UTF-8 support.


http://reviews.llvm.org/D13549