[PATCH] D13549: Added new options to ClangFormat VSIX package.

Manuel Klimek via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 12 01:25:01 PDT 2015


klimek added inline comments.

================
Comment at: lib/Driver/Tools.cpp:2356
@@ -2355,3 +2355,3 @@
     CmdArgs.push_back(
-        Args.MakeArgString("-dwarf-version=" + llvm::itostr(DwarfVersion)));
+        Args.MakeArgString("-dwarf-version=" + Twine(DwarfVersion)));
 }
----------------
Seems unrelated?

================
Comment at: tools/clang-format/ClangFormat.cpp:227
@@ -213,1 +226,3 @@
+      llvm::outs() << """;
+      break;
     default:
----------------
For XML, we should only need "<" and "&". Everything else is just important in a context introduced by "<" or "&".
The problem with include-sorting is that we'll now need to fully support utf8 input (well, any encoding, to be precise).
The best way is probably to escape all code points that are outside the ascii range. The problem I see is that we have no idea what encoding the file is in, so I have no clue how we can really resolve this.



http://reviews.llvm.org/D13549





More information about the cfe-commits mailing list