[libcxx] r249475 - Remove unnecessary inline functions capturing the contents of C library macros.

Richard Smith via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 7 14:43:43 PDT 2015


On Tue, Oct 6, 2015 at 3:31 PM, Jonathan Roelofs <jonathan at codesourcery.com>
wrote:

> On 10/6/15 4:03 PM, Richard Smith via cfe-commits wrote:
>
>> Author: rsmith
>> Date: Tue Oct  6 17:03:22 2015
>> New Revision: 249475
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=249475&view=rev
>> Log:
>> Remove unnecessary inline functions capturing the contents of C library
>> macros.
>>
>> The C standard requires that these be provided as functions even if
>> they're
>> also provided as macros, and a strict reading of the C++ standard library
>> rules
>> suggests that (for instance) &::isdigit == &::std::isdigit, so these
>> wrappers
>> are technically non-conforming.
>>
>
> Mind adding testcases to reinforce those identities, quoting the relevant
> bit(s) of the standard?


Sure, sounds like a good idea (but it's slightly tricky to test since
[global.functions]/2's footnote allows an implementation to declare
additional overloads of these functions).
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20151007/0c03e4f2/attachment.html>


More information about the cfe-commits mailing list