Fwd: [PATCH] D11328: [clang-tidy] new "throw-by-value-catch-by-reference" check for clang-tidy

[Tobias Langner via cfe-commits]

Hi,

I incorporated most of your changes. There are 2 open issues
- on one location I could not follow your advice, the compiler refused to compile the code. I chose a different approach and hope you like it.
- the second thing is this MaterializeTemporary advice that you gave. I don’t fully understand it (possibly due to a lack of understanding the AST and a lack of documentation of the proposed methods). Could you please flesh out your idea and why you think it is necessary? Or at least give an example where the current code does not work correctly.

Regards
Tobias

> Begin forwarded message:
> 
> From: Tobias Langner <randomcppprogrammer at gmail.com>
> Date: 8 October 2015 at 00:02:39 GMT+3
> To: randomcppprogrammer at gmail.com, klimek at google.com, cfe-commits at lists.llvm.org, aaron.ballman at gmail.com
> Cc: jon at jbcoe.net
> Subject: Re: [PATCH] D11328: [clang-tidy] new "throw-by-value-catch-by-reference" check for clang-tidy
> 
> randomcppprogrammer updated this revision to Diff 36795.
> randomcppprogrammer marked 11 inline comments as done.
> randomcppprogrammer added a comment.
> 
> Incorporated feedback from Aaron Ballmann
> 
> main changes:
> 
> - replaced isa followed by cast with dyn_cast
> - reworked comments
> - fixed typo in diagnosis message
> 
> 
> http://reviews.llvm.org/D11328
> 
> Files:
>  clang-tidy/misc/CMakeLists.txt
>  clang-tidy/misc/MiscTidyModule.cpp
>  clang-tidy/misc/ThrowByValueCatchByReferenceCheck.cpp
>  clang-tidy/misc/ThrowByValueCatchByReferenceCheck.h
>  test/clang-tidy/misc-throw-by-value-catch-by-reference.cpp
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20151008/755a13a2/attachment-0002.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D11328.36795.patch
Type: text/x-patch
Size: 15404 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20151008/755a13a2/attachment-0001.bin>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20151008/755a13a2/attachment-0003.html>