<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi,<div class=""><br class=""></div><div class="">I incorporated most of your changes. There are 2 open issues</div><div class="">- on one location I could not follow your advice, the compiler refused to compile the code. I chose a different approach and hope you like it.</div><div class="">- the second thing is this MaterializeTemporary advice that you gave. I don’t fully understand it (possibly due to a lack of understanding the AST and a lack of documentation of the proposed methods). Could you please flesh out your idea and why you think it is necessary? Or at least give an example where the current code does not work correctly.</div><div class=""><br class=""></div><div class="">Regards</div><div class="">Tobias<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">Begin forwarded message:</div><br class="Apple-interchange-newline"><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">From: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class="">Tobias Langner <<a href="mailto:randomcppprogrammer@gmail.com" class="">randomcppprogrammer@gmail.com</a>><br class=""></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">Date: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class="">8 October 2015 at 00:02:39 GMT+3<br class=""></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">To: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class=""><a href="mailto:randomcppprogrammer@gmail.com" class="">randomcppprogrammer@gmail.com</a>, <a href="mailto:klimek@google.com" class="">klimek@google.com</a>, <a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a>, <a href="mailto:aaron.ballman@gmail.com" class="">aaron.ballman@gmail.com</a><br class=""></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">Cc: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class=""><a href="mailto:jon@jbcoe.net" class="">jon@jbcoe.net</a><br class=""></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">Subject: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class=""><b class="">Re: [PATCH] D11328: [clang-tidy] new "throw-by-value-catch-by-reference" check for clang-tidy</b><br class=""></span></div><br class=""><div class=""><div class="">randomcppprogrammer updated this revision to Diff 36795.<br class="">randomcppprogrammer marked 11 inline comments as done.<br class="">randomcppprogrammer added a comment.<br class=""><br class="">Incorporated feedback from Aaron Ballmann<br class=""><br class="">main changes:<br class=""><br class="">- replaced isa followed by cast with dyn_cast<br class="">- reworked comments<br class="">- fixed typo in diagnosis message<br class=""><br class=""><br class=""><a href="http://reviews.llvm.org/D11328" class="">http://reviews.llvm.org/D11328</a><br class=""><br class="">Files:<br class=""> clang-tidy/misc/CMakeLists.txt<br class=""> clang-tidy/misc/MiscTidyModule.cpp<br class=""> clang-tidy/misc/ThrowByValueCatchByReferenceCheck.cpp<br class=""> clang-tidy/misc/ThrowByValueCatchByReferenceCheck.h<br class=""> test/clang-tidy/misc-throw-by-value-catch-by-reference.cpp<br class=""><br class=""></div></div></blockquote></div></div></body></html>