[PATCH] D12129: [libcxx] Add new Sphinx documentation

[Jonathan Roelofs via cfe-commits]

jroelofs added inline comments.

================
Comment at: docs/BuildingLibcxx.rst:57
@@ +56,3 @@
+  select a safe place to install libc++.
+
+  * ``make install-libcxx install-libcxxabi`` --- Will install the libraries and the headers
----------------
I feel like a warning is not enough... perhaps a hard error, with a message that says something like: "If you're really really sure you know what you're doing, add -DLIBCXX_OVERRIDE_DARWIN_INSTALL=YES to silence this message"?

================
Comment at: docs/index.rst:88
@@ +87,3 @@
+OS           Arch                 Compilers    ABI Library
+============ ==================== ============ ========================
+Mac OS X     i386, x86_64         Clang, GCC   libc++abi
----------------
Yeah. This is good for now. I just wanted to mention it while I was thinking of it.


http://reviews.llvm.org/D12129