[PATCH] D12129: [libcxx] Add new Sphinx documentation

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 20 11:45:43 PDT 2015


EricWF added inline comments.

================
Comment at: docs/BuildingLibcxx.rst:56
@@ +55,3 @@
+Mac users, remember to be careful when replacing the system's libc++.
+**Your system will not be able to boot without a functioning libc++.**
+
----------------
jroelofs wrote:
> Is there a way to make this more prominent, perhaps by putting it in a red box? This is a very important detail that is very painful to recover from if you miss it.
I'll make it happen. I was also thinking about adding loud CMake warnings whenever CMake tries to install libc++ to `/usr` on OS X. 

================
Comment at: docs/index.rst:87
@@ +86,3 @@
+============ ==================== ============ ========================
+OS           Arch                 Compilers    ABI Library
+============ ==================== ============ ========================
----------------
jroelofs wrote:
> Should we mention the unwinders used/supported here too?
Sure but can we do that later? I have no clue what platforms support what and I would have to get some input on that.


http://reviews.llvm.org/D12129





More information about the cfe-commits mailing list