[PATCH] D12119: Analyzer: Fix a crasher in UbigraphViz

[Ted Kremenek via cfe-commits]

krememek added inline comments.

================
Comment at: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:749
@@ -748,3 +748,3 @@
 
   assert (Src != Dst && "Self-edges are not allowed.");
 
----------------
ismailp wrote:
> Is Ubigraph generator actively maintained? If I run tests with '-analyzer-viz-egraph-ubigraph', this assertion gets triggered. According to static analyzer documentation, cycles are allowed in ExplodedGraph. I am unsure whether self-cycles are allowed, however.
There was a time where a self-cycle indicated a bug in the analyzer.  Much has changed since destructor support was added, but the Ubigraph support hasn't bitrotted.  It could be the case that this assertion needs to be removed because an invariant in the analyzer has changed, but I would be willing to also say it is possible that the tests are failing because an invariant is getting violated.


http://reviews.llvm.org/D12119