[PATCH] D12119: Analyzer: Fix a crasher in UbigraphViz

Ted Kremenek via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 18 15:18:08 PDT 2015


krememek added inline comments.

================
Comment at: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:784
@@ -783,3 +783,3 @@
 
-  *Out << "('vertex_style_attribute', 0, ('shape', 'icosahedron'))\n";
-  *Out << "('vertex_style', 1, 0, ('shape', 'sphere'), ('color', '#ffcc66'),"
+  *this->Out << "('vertex_style_attribute', 0, ('shape', 'icosahedron'))\n";
+  *this->Out << "('vertex_style', 1, 0, ('shape', 'sphere'), ('color', '#ffcc66'),"
----------------
This seems really brittle.

Can we just rename the parameter 'Out' to something else, and then just use 'Out'?  Seems more reasonable to rename the parameter than to change every single functional line of code that uses 'Out'.


http://reviews.llvm.org/D12119





More information about the cfe-commits mailing list