[clang-tools-extra] r245052 - [clang-tidy] Move IncludeSorter.* and IncludeInserter.* to clang-tidy/utils/

[Alexander Kornienko via cfe-commits]

... or this may have been fixed by r245144. In any case, please check again
and report if anything is still broken.

On Sat, Aug 15, 2015 at 7:39 AM, Alexander Kornienko <alexfh at google.com>
wrote:

> Sorry for not posting an update earlier.
>
> I can't reproduce the build failure, and I see no build bots failing in a
> similar way. Must be something with your local configuration.
>
>
> On Fri, Aug 14, 2015 at 7:47 PM, Alexander Kornienko <alexfh at google.com>
> wrote:
>
>> Strange. No build bots complained about this so far. I'll take a look at
>> this in an hour or so.
>> On 14 Aug 2015 19:42, "İsmail Dönmez" <ismail at i10z.com> wrote:
>>
>>> Hi,
>>>
>>> On Fri, Aug 14, 2015 at 5:31 PM, Alexander Kornienko via cfe-commits
>>> <cfe-commits at lists.llvm.org> wrote:
>>> > Author: alexfh
>>> > Date: Fri Aug 14 09:31:31 2015
>>> > New Revision: 245052
>>> >
>>> > URL: http://llvm.org/viewvc/llvm-project?rev=245052&view=rev
>>> > Log:
>>> > [clang-tidy] Move IncludeSorter.* and IncludeInserter.* to
>>> clang-tidy/utils/
>>> >
>>> > This is better structurally and it also fixes a linker error in the
>>> configure
>>> > build.
>>>
>>> This seems to break cmake build on Linux:
>>>
>>> FAILED: : && /home/abuild/rpmbuild/BUILD/llvm/stage1/bin/clang++
>>> -fPIC -fuse-ld=gold -stdlib=libc++ -fPIC -fvisibility-inlines-hidden
>>> -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual
>>> -Wmissing-field-initializers -pedantic -Wno-long-long
>>> -Wcovered-switch-default -Wnon-virtual-dtor -Werror=date-time
>>> -std=c++11 -fcolor-diagnostics -ffunction-sections -fdata-sections
>>> -fno-common -Woverloaded-virtual -fno-strict-aliasing
>>> -Wno-nested-anon-types -O2 -g  -stdlib=libc++ -Wl,-z,defs   -Wl,-O3
>>> -Wl,--gc-sections -shared
>>> -Wl,-soname,libclangTidyModernizeModule.so.3.8 -o
>>> lib64/libclangTidyModernizeModule.so.3.8.0svn
>>>
>>> tools/clang/tools/extra/clang-tidy/modernize/CMakeFiles/clangTidyModernizeModule.dir/ModernizeTidyModule.cpp.o
>>>
>>> tools/clang/tools/extra/clang-tidy/modernize/CMakeFiles/clangTidyModernizeModule.dir/PassByValueCheck.cpp.o
>>>  lib64/libclangAST.so.3.8.0svn lib64/libclangASTMatchers.so.3.8.0svn
>>> lib64/libclangBasic.so.3.8.0svn lib64/libclangLex.so.3.8.0svn
>>> lib64/libclangTidy.so.3.8.0svn
>>> lib64/libclangTidyReadabilityModule.so.3.8.0svn
>>> lib64/libLLVMSupport.so.3.8.0svn -Wl,-rpath,"\$ORIGIN/../lib64" && :
>>> ../tools/clang/tools/extra/clang-tidy/modernize/PassByValueCheck.cpp:169:
>>> error: undefined reference to
>>> 'clang::tidy::IncludeInserter::IncludeInserter(clang::SourceManager
>>> const&, clang::LangOptions const&,
>>> clang::tidy::IncludeSorter::IncludeStyle)'
>>>
>>> /home/abuild/rpmbuild/BUILD/llvm/stage1/bin/../include/c++/v1/memory:2516:
>>> error: undefined reference to
>>> 'clang::tidy::IncludeInserter::~IncludeInserter()'
>>> ../tools/clang/tools/extra/clang-tidy/modernize/PassByValueCheck.cpp:171:
>>> error: undefined reference to
>>> 'clang::tidy::IncludeInserter::CreatePPCallbacks()'
>>> ../tools/clang/tools/extra/clang-tidy/modernize/PassByValueCheck.cpp:215:
>>> error: undefined reference to
>>> 'clang::tidy::IncludeInserter::CreateIncludeInsertion(clang::FileID,
>>> llvm::StringRef, bool)'
>>>
>>> /home/abuild/rpmbuild/BUILD/llvm/stage1/bin/../include/c++/v1/memory:2516:
>>> error: undefined reference to
>>> 'clang::tidy::IncludeInserter::~IncludeInserter()'
>>>
>>> /home/abuild/rpmbuild/BUILD/llvm/stage1/bin/../include/c++/v1/memory:2516:
>>> error: undefined reference to
>>> 'clang::tidy::IncludeInserter::~IncludeInserter()'
>>> clang-3.8: error: linker command failed with exit code 1 (use -v to
>>> see invocation)
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150815/894c25c9/attachment.html>