<div dir="ltr">... or this may have been fixed by r245144. In any case, please check again and report if anything is still broken.<br><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Aug 15, 2015 at 7:39 AM, Alexander Kornienko <span dir="ltr"><<a href="mailto:alexfh@google.com" target="_blank">alexfh@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Sorry for not posting an update earlier.<div><br></div><div>I can't reproduce the build failure, and I see no build bots failing in a similar way. Must be something with your local configuration.<div><div class="h5"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Aug 14, 2015 at 7:47 PM, Alexander Kornienko <span dir="ltr"><<a href="mailto:alexfh@google.com" target="_blank">alexfh@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">Strange. No build bots complained about this so far. I'll take a look at this in an hour or so.</p><div><div>
<div class="gmail_quote">On 14 Aug 2015 19:42, "İsmail Dönmez" <<a href="mailto:ismail@i10z.com" target="_blank">ismail@i10z.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
On Fri, Aug 14, 2015 at 5:31 PM, Alexander Kornienko via cfe-commits<br>
<<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br>
> Author: alexfh<br>
> Date: Fri Aug 14 09:31:31 2015<br>
> New Revision: 245052<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=245052&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=245052&view=rev</a><br>
> Log:<br>
> [clang-tidy] Move IncludeSorter.* and IncludeInserter.* to clang-tidy/utils/<br>
><br>
> This is better structurally and it also fixes a linker error in the configure<br>
> build.<br>
<br>
This seems to break cmake build on Linux:<br>
<br>
FAILED: : && /home/abuild/rpmbuild/BUILD/llvm/stage1/bin/clang++<br>
-fPIC -fuse-ld=gold -stdlib=libc++ -fPIC -fvisibility-inlines-hidden<br>
-Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual<br>
-Wmissing-field-initializers -pedantic -Wno-long-long<br>
-Wcovered-switch-default -Wnon-virtual-dtor -Werror=date-time<br>
-std=c++11 -fcolor-diagnostics -ffunction-sections -fdata-sections<br>
-fno-common -Woverloaded-virtual -fno-strict-aliasing<br>
-Wno-nested-anon-types -O2 -g  -stdlib=libc++ -Wl,-z,defs   -Wl,-O3<br>
-Wl,--gc-sections -shared<br>
-Wl,-soname,libclangTidyModernizeModule.so.3.8 -o<br>
lib64/libclangTidyModernizeModule.so.3.8.0svn<br>
tools/clang/tools/extra/clang-tidy/modernize/CMakeFiles/clangTidyModernizeModule.dir/ModernizeTidyModule.cpp.o<br>
tools/clang/tools/extra/clang-tidy/modernize/CMakeFiles/clangTidyModernizeModule.dir/PassByValueCheck.cpp.o<br>
 lib64/libclangAST.so.3.8.0svn lib64/libclangASTMatchers.so.3.8.0svn<br>
lib64/libclangBasic.so.3.8.0svn lib64/libclangLex.so.3.8.0svn<br>
lib64/libclangTidy.so.3.8.0svn<br>
lib64/libclangTidyReadabilityModule.so.3.8.0svn<br>
lib64/libLLVMSupport.so.3.8.0svn -Wl,-rpath,"\$ORIGIN/../lib64" && :<br>
../tools/clang/tools/extra/clang-tidy/modernize/PassByValueCheck.cpp:169:<br>
error: undefined reference to<br>
'clang::tidy::IncludeInserter::IncludeInserter(clang::SourceManager<br>
const&, clang::LangOptions const&,<br>
clang::tidy::IncludeSorter::IncludeStyle)'<br>
/home/abuild/rpmbuild/BUILD/llvm/stage1/bin/../include/c++/v1/memory:2516:<br>
error: undefined reference to<br>
'clang::tidy::IncludeInserter::~IncludeInserter()'<br>
../tools/clang/tools/extra/clang-tidy/modernize/PassByValueCheck.cpp:171:<br>
error: undefined reference to<br>
'clang::tidy::IncludeInserter::CreatePPCallbacks()'<br>
../tools/clang/tools/extra/clang-tidy/modernize/PassByValueCheck.cpp:215:<br>
error: undefined reference to<br>
'clang::tidy::IncludeInserter::CreateIncludeInsertion(clang::FileID,<br>
llvm::StringRef, bool)'<br>
/home/abuild/rpmbuild/BUILD/llvm/stage1/bin/../include/c++/v1/memory:2516:<br>
error: undefined reference to<br>
'clang::tidy::IncludeInserter::~IncludeInserter()'<br>
/home/abuild/rpmbuild/BUILD/llvm/stage1/bin/../include/c++/v1/memory:2516:<br>
error: undefined reference to<br>
'clang::tidy::IncludeInserter::~IncludeInserter()'<br>
clang-3.8: error: linker command failed with exit code 1 (use -v to<br>
see invocation)<br>
</blockquote></div>
</div></div></blockquote></div><br>
</div></div></div></div></div>
</blockquote></div><br>
</div></div>