[PATCH] D12002: Initial WebAssembly support in clang

JF Bastien via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 14 18:05:12 PDT 2015


jfb accepted this revision.
jfb added a comment.
This revision is now accepted and ready to land.

lgtm


================
Comment at: lib/Basic/Targets.cpp:7002
@@ +7001,3 @@
+  bool isCLZForZeroUndef() const override final { return false; }
+  bool hasInt128Type() const override final { return true; }
+};
----------------
Does int 128 get expanded in legalization? Seems good.

================
Comment at: test/Preprocessor/init.c:8478
@@ +8477,3 @@
+// WEBASSEMBLY32:#define __GCC_ATOMIC_LONG_LOCK_FREE 1{{$}}
+// WEBASSEMBLY32:#define __GCC_ATOMIC_POINTER_LOCK_FREE 1{{$}}
+// WEBASSEMBLY32:#define __GCC_ATOMIC_SHORT_LOCK_FREE 1{{$}}
----------------
sunfish wrote:
> Ok, I've set MaxAtomicInlineWidth to 0 for now so that we don't block the rest of the patch on this issue.
> 
> N4509 is just about exposing the same information via a different interface.
`constexpr` makes a world of difference I'm told :-)


Repository:
  rL LLVM

http://reviews.llvm.org/D12002





More information about the cfe-commits mailing list