[PATCH] D12002: Initial WebAssembly support in clang

Dan Gohman via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 14 15:27:31 PDT 2015


sunfish added inline comments.

================
Comment at: lib/Basic/Targets.cpp:7010
@@ +7009,3 @@
+  { #ID, TYPE, ATTRS, HEADER, ALL_LANGUAGES, nullptr },
+#include "clang/Basic/BuiltinsWebAssembly.def"
+};
----------------
WebAssembly32TargetInfo is subclassed in LLVM code, and getTargetDefines is overridden.

================
Comment at: test/Preprocessor/init.c:8478
@@ +8477,3 @@
+// WEBASSEMBLY32:#define __GCC_ATOMIC_LONG_LOCK_FREE 1{{$}}
+// WEBASSEMBLY32:#define __GCC_ATOMIC_POINTER_LOCK_FREE 1{{$}}
+// WEBASSEMBLY32:#define __GCC_ATOMIC_SHORT_LOCK_FREE 1{{$}}
----------------
Ok, I've set MaxAtomicInlineWidth to 0 for now so that we don't block the rest of the patch on this issue.

N4509 is just about exposing the same information via a different interface.


Repository:
  rL LLVM

http://reviews.llvm.org/D12002





More information about the cfe-commits mailing list