[PATCH] D11614: testing for tail call optimization repression when sanitizing use-after-dtor

Evgeniy Stepanov eugenis at google.com
Wed Jul 29 16:26:33 PDT 2015


eugenis added inline comments.

================
Comment at: test/msan/dtor-tail-call.cc:35
@@ +34,3 @@
+  // CHECK: WARNING: MemorySanitizer: use-of-uninitialized-value
+  // CHECK: {{#0 0x.* in main .*dtor-tail-call.cc:32}}
+
----------------
Use @LINE to refer to line numbers in the test case.

================
Comment at: test/msan/dtor-tail-call.cc:37
@@ +36,3 @@
+
+  // CHECK-OPT: WARNING: MemorySanitizer: use-of-uninitialized-value
+  // CHECK-OPT: {{#0 0x.* in main .*dtor-tail-call.cc:32}}
----------------
You don't need a 'CHECK-OPT' if it's the same as 'CHECK'

================
Comment at: test/msan/dtor-tail-call.cc:41
@@ +40,3 @@
+  // CHECK-ORIGINS: Memory was marked as uninitialized
+  // CHECK-ORIGINS: {{#0 0x.* in __sanitizer_dtor_callback .*msan_interceptors.cc:1009}}
+  // CHECK-ORIGINS: {{#1 0x.* in Simple::~Simple()}}
----------------
Don't refer to the line numbers in other files, they will change.
In this case it would be ok to end the line after __sanitizer_dtor_callback}}


http://reviews.llvm.org/D11614







More information about the cfe-commits mailing list