[PATCH] D11614: testing for tail call optimization repression when sanitizing use-after-dtor

[Naomi Musgrave]

nmusgrave created this revision.
nmusgrave added reviewers: eugenis, kcc.
nmusgrave added a subscriber: cfe-commits.

Verify that running in optimized mode while checking for use-after-dtor errors, does not generate tail call invocation of destructor. This avoids possible error where stack frame for the destructor is eliminated, making tracking down the errors more difficult.

http://reviews.llvm.org/D11614

Files:
  test/msan/dtor-tail-call.cc

Index: test/msan/dtor-tail-call.cc
===================================================================
--- /dev/null
+++ test/msan/dtor-tail-call.cc
@@ -0,0 +1,46 @@
+// RUN: %clangxx_msan %s -fsanitize=memory -fsanitize-memory-use-after-dtor -o %t && MSAN_OPTIONS=poison_in_dtor=1 not %run %t >%t.out 2>&1
+// RUN: FileCheck %s < %t.out
+
+// RUN: %clangxx_msan %s -O1 -fsanitize=memory -fsanitize-memory-use-after-dtor -o %t && MSAN_OPTIONS=poison_in_dtor=1 not %run %t >%t.out 2>&1
+// RUN: FileCheck %s --check-prefix=CHECK-OPT < %t.out
+
+// RUN: %clangxx_msan %s -O1 -fsanitize=memory -fsanitize-memory-use-after-dtor -fsanitize-memory-track-origins -o %t && MSAN_OPTIONS=poison_in_dtor=1 not %run %t >%t.out 2>&1
+// RUN: FileCheck %s --check-prefix=CHECK-ORIGINS < %t.out
+
+#include <sanitizer/msan_interface.h>
+#include <assert.h>
+#include <stdio.h>
+#include <new>
+
+struct Simple {
+  int x_;
+  Simple() {
+    x_ = 5;
+  }
+  ~Simple() {
+    x_ += 1;
+  }
+};
+
+int main() {
+  unsigned long buf[1];
+  assert(sizeof(Simple) <= sizeof(buf));
+
+  Simple *s = new(&buf) Simple();
+  s->~Simple();
+
+  return s->x_;
+
+  // CHECK: WARNING: MemorySanitizer: use-of-uninitialized-value
+  // CHECK: {{#0 0x.* in main .*dtor-tail-call.cc:32}}
+
+  // CHECK-OPT: WARNING: MemorySanitizer: use-of-uninitialized-value
+  // CHECK-OPT: {{#0 0x.* in main .*dtor-tail-call.cc:32}}
+
+  // CHECK-ORIGINS: Memory was marked as uninitialized
+  // CHECK-ORIGINS: {{#0 0x.* in __sanitizer_dtor_callback .*msan_interceptors.cc:1009}}
+  // CHECK-ORIGINS: {{#1 0x.* in Simple::~Simple()}}
+
+  // CHECK: SUMMARY: MemorySanitizer: use-of-uninitialized-value {{.*main}}
+  // CHECK-OPT: SUMMARY: MemorySanitizer: use-of-uninitialized-value {{.*main}}
+}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D11614.30966.patch
Type: text/x-patch
Size: 1755 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150729/7006ab25/attachment.bin>