r243417 - RegParmMax must be 0 for AArch64, as the regparm function attribute is not supported on AArch64.

[Kristof Beyls]

Could be a good idea.

Hans, is the 3.7 branch still open for backports of bug fixes?

If so, I’ll merge this to 3.7 tomorrow.

 

Thanks,

 

Kristof

 

From: James Molloy [mailto:james at jamesmolloy.co.uk] 
Sent: 28 July 2015 16:15
To: Kristof Beyls; llvm cfe
Subject: Re: r243417 - RegParmMax must be 0 for AArch64, as the regparm function attribute is not supported on AArch64.

 

Hi Kristof,

 

As this causes a crash and is a trivial fix, would it be worth getting it merged to 3.7?

 

Cheers,

 

James

 

On Tue, 28 Jul 2015 at 15:31 Kristof Beyls <kristof.beyls at arm.com> wrote:

Author: kbeyls
Date: Tue Jul 28 09:23:47 2015
New Revision: 243417

URL: http://llvm.org/viewvc/llvm-project?rev=243417 <http://llvm.org/viewvc/llvm-project?rev=243417&view=rev> &view=rev
Log:
RegParmMax must be 0 for AArch64, as the regparm function attribute is not supported on AArch64.


Modified:
    cfe/trunk/lib/Basic/Targets.cpp
    cfe/trunk/test/CodeGen/le32-regparm.c

Modified: cfe/trunk/lib/Basic/Targets.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets.cpp?rev=243417 <http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets.cpp?rev=243417&r1=243416&r2=243417&view=diff> &r1=243416&r2=243417&view=diff
==============================================================================
--- cfe/trunk/lib/Basic/Targets.cpp (original)
+++ cfe/trunk/lib/Basic/Targets.cpp Tue Jul 28 09:23:47 2015
@@ -5082,7 +5082,6 @@ public:

     LongWidth = LongAlign = PointerWidth = PointerAlign = 64;
     MaxVectorAlign = 128;
-    RegParmMax = 8;
     MaxAtomicInlineWidth = 128;
     MaxAtomicPromoteWidth = 128;


Modified: cfe/trunk/test/CodeGen/le32-regparm.c
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/le32-regparm.c?rev=243417 <http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/le32-regparm.c?rev=243417&r1=243416&r2=243417&view=diff> &r1=243416&r2=243417&view=diff
==============================================================================
--- cfe/trunk/test/CodeGen/le32-regparm.c (original)
+++ cfe/trunk/test/CodeGen/le32-regparm.c Tue Jul 28 09:23:47 2015
@@ -1,4 +1,5 @@
 // RUN: %clang_cc1 -triple le32-unknown-nacl %s -fsyntax-only -verify
+// RUN: %clang_cc1 -triple aarch64 %s -fsyntax-only -verify

 void __attribute__((regparm(2))) fc_f1(int i, int j, int k) {} // expected-error{{'regparm' is not valid on this platform}}



_______________________________________________
cfe-commits mailing list
cfe-commits at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150728/004df668/attachment.html>