<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 14 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-GB link=blue vlink=purple><div class=WordSection1><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Could be a good idea.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Hans, is the 3.7 branch still open for backports of bug fixes?<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>If so, I’ll merge this to 3.7 tomorrow.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Thanks,<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Kristof<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><div style='border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt'><div><div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p class=MsoNormal><b><span lang=EN-US style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span lang=EN-US style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'> James Molloy [mailto:james@jamesmolloy.co.uk] <br><b>Sent:</b> 28 July 2015 16:15<br><b>To:</b> Kristof Beyls; llvm cfe<br><b>Subject:</b> Re: r243417 - RegParmMax must be 0 for AArch64, as the regparm function attribute is not supported on AArch64.<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><div><p class=MsoNormal>Hi Kristof,<o:p></o:p></p><div><p class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>As this causes a crash and is a trivial fix, would it be worth getting it merged to 3.7?<o:p></o:p></p></div><div><p class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>Cheers,<o:p></o:p></p></div><div><p class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>James<o:p></o:p></p></div><p class=MsoNormal><o:p> </o:p></p><div><div><p class=MsoNormal>On Tue, 28 Jul 2015 at 15:31 Kristof Beyls <<a href="mailto:kristof.beyls@arm.com">kristof.beyls@arm.com</a>> wrote:<o:p></o:p></p></div><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm'><p class=MsoNormal>Author: kbeyls<br>Date: Tue Jul 28 09:23:47 2015<br>New Revision: 243417<br><br>URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D243417-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=TBd6dBg_RNoNO5_lKRFB5nnlmheazSms4TTenp3fKew&s=6IhUkSs8IztIHdfMyjBDjyngqEQE9lTa_DodaPCXIgY&e=" target="_blank">http://llvm.org/viewvc/llvm-project?rev=243417&view=rev</a><br>Log:<br>RegParmMax must be 0 for AArch64, as the regparm function attribute is not supported on AArch64.<br><br><br>Modified:<br> cfe/trunk/lib/Basic/Targets.cpp<br> cfe/trunk/test/CodeGen/le32-regparm.c<br><br>Modified: cfe/trunk/lib/Basic/Targets.cpp<br>URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_cfe_trunk_lib_Basic_Targets.cpp-3Frev-3D243417-26r1-3D243416-26r2-3D243417-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=TBd6dBg_RNoNO5_lKRFB5nnlmheazSms4TTenp3fKew&s=Rk_NlrHlIuaRk7gKwxQR9x75XDyEyOwi8wu5x35mxZU&e=" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets.cpp?rev=243417&r1=243416&r2=243417&view=diff</a><br>==============================================================================<br>--- cfe/trunk/lib/Basic/Targets.cpp (original)<br>+++ cfe/trunk/lib/Basic/Targets.cpp Tue Jul 28 09:23:47 2015<br>@@ -5082,7 +5082,6 @@ public:<br><br> LongWidth = LongAlign = PointerWidth = PointerAlign = 64;<br> MaxVectorAlign = 128;<br>- RegParmMax = 8;<br> MaxAtomicInlineWidth = 128;<br> MaxAtomicPromoteWidth = 128;<br><br><br>Modified: cfe/trunk/test/CodeGen/le32-regparm.c<br>URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_cfe_trunk_test_CodeGen_le32-2Dregparm.c-3Frev-3D243417-26r1-3D243416-26r2-3D243417-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=TBd6dBg_RNoNO5_lKRFB5nnlmheazSms4TTenp3fKew&s=N7wyiXWOqKcWLcZEV1RE-Yz54-k1RcwKQbaS2q7iztw&e=" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/le32-regparm.c?rev=243417&r1=243416&r2=243417&view=diff</a><br>==============================================================================<br>--- cfe/trunk/test/CodeGen/le32-regparm.c (original)<br>+++ cfe/trunk/test/CodeGen/le32-regparm.c Tue Jul 28 09:23:47 2015<br>@@ -1,4 +1,5 @@<br> // RUN: %clang_cc1 -triple le32-unknown-nacl %s -fsyntax-only -verify<br>+// RUN: %clang_cc1 -triple aarch64 %s -fsyntax-only -verify<br><br> void __attribute__((regparm(2))) fc_f1(int i, int j, int k) {} // expected-error{{'regparm' is not valid on this platform}}<br><br><br><br>_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><o:p></o:p></p></blockquote></div></div></div></div></body></html>