[clang-tools-extra] r242984 - Appease test/clang-tidy/misc-unused-parameters.cpp for targeting *-win32, to add -fno-delayed-template-parsing.

[Alexander Kornienko]

On Thu, Jul 23, 2015 at 7:52 AM, NAKAMURA Takumi <geek4civic at gmail.com>
wrote:

> Author: chapuni
> Date: Thu Jul 23 00:52:02 2015
> New Revision: 242984
>
> URL: http://llvm.org/viewvc/llvm-project?rev=242984&view=rev
> Log:
> Appease test/clang-tidy/misc-unused-parameters.cpp for targeting *-win32,
> to add -fno-delayed-template-parsing.
>
> Note, clang-tidy tests wouldn't run on Windows hosts since they are
> disabled with REQUIRES:shell.
> The failure would be raised with cross building.
>
> Modified:
>     clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy.sh
>
> Modified: clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy.sh
> URL:
> http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy.sh?rev=242984&r1=242983&r2=242984&view=diff
>
> ==============================================================================
> --- clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy.sh (original)
> +++ clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy.sh Thu Jul 23
> 00:52:02 2015
> @@ -17,6 +17,8 @@ shift 3
>  if [ "$#" -eq 0 ] ; then
>    # Default to -- --std=c++11
>    set - -- --std=c++11
> +  # Suppress -target=*-win32.
>

I don't understand how this comment relates to the next line. Could you
explain this and also what exactly is the problem with *-win32 targets and
delayed template parsing?

Also, if the issue only relates to the misc-unused-parameters.cpp test, why
not put the extra options there?


> +  set - -- -fno-delayed-template-parsing
>  fi
>
>  set -o errexit
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>

-- Alex
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150725/5df0aba9/attachment.html>