<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Jul 23, 2015 at 7:52 AM, NAKAMURA Takumi <span dir="ltr"><<a href="mailto:geek4civic@gmail.com" target="_blank">geek4civic@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: chapuni<br>
Date: Thu Jul 23 00:52:02 2015<br>
New Revision: 242984<br>
<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D242984-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=HxyYgVm-W2wdbWHTZOyW8UnmDnOAbmte_qFLQXcsUc0&s=X1S23T8gW0I9ED2pZkzC-SxsnbHyvp01S5KUdCManeE&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=242984&view=rev</a><br>
Log:<br>
Appease test/clang-tidy/misc-unused-parameters.cpp for targeting *-win32, to add -fno-delayed-template-parsing.<br>
<br>
Note, clang-tidy tests wouldn't run on Windows hosts since they are disabled with REQUIRES:shell.<br>
The failure would be raised with cross building.<br>
<br>
Modified:<br>
    clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy.sh<br>
<br>
Modified: clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy.sh<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_clang-2Dtools-2Dextra_trunk_test_clang-2Dtidy_check-5Fclang-5Ftidy.sh-3Frev-3D242984-26r1-3D242983-26r2-3D242984-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=HxyYgVm-W2wdbWHTZOyW8UnmDnOAbmte_qFLQXcsUc0&s=ACv0L4XSlrWeAtCYI9CrX0vHLK6zwJjjo-fPN8mijgM&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy.sh?rev=242984&r1=242983&r2=242984&view=diff</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy.sh (original)<br>
+++ clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy.sh Thu Jul 23 00:52:02 2015<br>
@@ -17,6 +17,8 @@ shift 3<br>
 if [ "$#" -eq 0 ] ; then<br>
   # Default to -- --std=c++11<br>
   set - -- --std=c++11<br>
+  # Suppress -target=*-win32.<br></blockquote><div><br></div><div>I don't understand how this comment relates to the next line. Could you explain this and also what exactly is the problem with *-win32 targets and delayed template parsing?</div><div><br></div><div>Also, if the issue only relates to the misc-unused-parameters.cpp test, why not put the extra options there?</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
+  set - -- -fno-delayed-template-parsing<br>
 fi<br>
<br>
 set -o errexit<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br>
</div><div class="gmail_extra">-- Alex</div></div>