[PATCH] D11441: Generating available_externally vtables for classes without inline virtual functions

John McCall rjmccall at gmail.com
Thu Jul 23 12:39:51 PDT 2015


rjmccall added inline comments.

================
Comment at: lib/CodeGen/ItaniumCXXABI.cpp:1509
@@ +1508,3 @@
+  // FIXME we can still emit a copy of the vtable if we
+  // can emit definition of the inline functions.
+  if (CGM.getLangOpts().AppleKext)
----------------
Please move this FIXME down after the other comment.  It doesn't apply to the logic about apple kexts, which is unconditional.


http://reviews.llvm.org/D11441







More information about the cfe-commits mailing list